Skip to content

Conversation

@tpellissier-msft
Copy link
Collaborator

@tpellissier-msft tpellissier-msft commented Jan 20, 2026

Use ASCII equivalents for better cross-platform compatibility (eg. with Claude Code):

  • ✓ -> [OK]
  • ⚠ -> [WARN]
  • → -> ->
  • ↺ -> [INFO] (for backoff retry success messages)

Updated example files: walkthrough.py, file_upload.py, functional_testing.py, installation_example.py

Use ASCII equivalents for better cross-platform compatibility:
- ✓ -> [OK]
- ⚠ -> [WARN] (outside backoff function)
- → -> ->

Note: Unicode characters in the backoff() function are intentionally
preserved to avoid merge conflicts with other PRs that refactor
the backoff helper.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@tpellissier-msft tpellissier-msft requested a review from a team as a code owner January 20, 2026 19:42
Copilot AI review requested due to automatic review settings January 20, 2026 19:42
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces Unicode characters with ASCII equivalents in example output for better cross-platform compatibility (e.g., with Claude Code). The changes ensure that example scripts produce output that renders consistently across different terminal environments.

Changes:

  • Replace Unicode arrow (→) with ASCII arrow (->) in logging helper
  • Replace Unicode checkmarks (✓) with [OK] tags in success messages
  • Replace Unicode warning symbol (⚠) with [WARN] tag in error messages
  • Minor formatting cleanup (blank line removal)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
examples/advanced/walkthrough.py Replaced Unicode characters (✓, ⚠, →) with ASCII equivalents ([OK], [WARN], ->) in print statements throughout the example script
src/PowerPlatform/Dataverse/data/_odata.py Removed extraneous blank line for code formatting consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zhaodongwang-msft
Copy link
Collaborator

there are also unicode usage in file_upload.py, functional_testing.py, installation_example.py. should we update those too?

Address PR review comment to update unicode characters in additional
example files (file_upload.py, functional_testing.py, installation_example.py)
for cross-platform terminal compatibility.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address PR review feedback: use bracketed tags consistently
throughout (e.g., [INFO], [WARN], [OK]) instead of mixing
asterisks with bracketed tags.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tpellissier-msft tpellissier-msft merged commit 09ff1fe into main Jan 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants