-
Notifications
You must be signed in to change notification settings - Fork 11
Replace Unicode characters with ASCII in example output #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use ASCII equivalents for better cross-platform compatibility: - ✓ -> [OK] - ⚠ -> [WARN] (outside backoff function) - → -> -> Note: Unicode characters in the backoff() function are intentionally preserved to avoid merge conflicts with other PRs that refactor the backoff helper. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces Unicode characters with ASCII equivalents in example output for better cross-platform compatibility (e.g., with Claude Code). The changes ensure that example scripts produce output that renders consistently across different terminal environments.
Changes:
- Replace Unicode arrow (→) with ASCII arrow (->) in logging helper
- Replace Unicode checkmarks (✓) with [OK] tags in success messages
- Replace Unicode warning symbol (⚠) with [WARN] tag in error messages
- Minor formatting cleanup (blank line removal)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/advanced/walkthrough.py | Replaced Unicode characters (✓, ⚠, →) with ASCII equivalents ([OK], [WARN], ->) in print statements throughout the example script |
| src/PowerPlatform/Dataverse/data/_odata.py | Removed extraneous blank line for code formatting consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
there are also unicode usage in file_upload.py, functional_testing.py, installation_example.py. should we update those too? |
Address PR review comment to update unicode characters in additional example files (file_upload.py, functional_testing.py, installation_example.py) for cross-platform terminal compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address PR review feedback: use bracketed tags consistently throughout (e.g., [INFO], [WARN], [OK]) instead of mixing asterisks with bracketed tags. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use ASCII equivalents for better cross-platform compatibility (eg. with Claude Code):
Updated example files: walkthrough.py, file_upload.py, functional_testing.py, installation_example.py